will/adopt-a-street
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(models/point-transaction): align find() consumers to array API and correct balance/history accessors\n\nUpdates findByUser/findByType/getUserBalance/getUserTransactionHistory to consume couchdbService.find as an array, removing result.docs assumptions. Prevents undefined access and ensures correct balance retrieval.\n\n🤖 Generated with [AI Assistant]\n\nCo-Authored-By: AI Assistant <noreply@ai-assistant.com>

Browse Source
This commit is contained in:
William Valentin
2025-11-04 10:56:20 -08:00
parent cfc9b09a1f
commit d2e12ef23d
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
backend/models/PointTransaction.js
View File

@@ -90,7 +90,7 @@ class PointTransaction {
const errorContext = createErrorContext('PointTransaction', 'findByUser', { userId, limit, skip }); const errorContext = createErrorContext('PointTransaction', 'findByUser', { userId, limit, skip });
return await withErrorHandling(async () => { return await withErrorHandling(async () => {
const result = await couchdbService.find({ const docs = await couchdbService.find({
selector: { selector: {
type: 'point_transaction', type: 'point_transaction',
user: userId user: userId
@@ -99,7 +99,7 @@ class PointTransaction {
limit: limit, limit: limit,
skip: skip skip: skip
}); });
return result.docs; return docs;
}, errorContext); }, errorContext);
} }
@@ -107,7 +107,7 @@ class PointTransaction {
const errorContext = createErrorContext('PointTransaction', 'findByType', { transactionType, limit, skip }); const errorContext = createErrorContext('PointTransaction', 'findByType', { transactionType, limit, skip });
return await withErrorHandling(async () => { return await withErrorHandling(async () => {
const result = await couchdbService.find({ const docs = await couchdbService.find({
selector: { selector: {
type: 'point_transaction', type: 'point_transaction',
transactionType: transactionType transactionType: transactionType
@@ -116,7 +116,7 @@ class PointTransaction {
limit: limit, limit: limit,
skip: skip skip: skip
}); });
return result.docs; return docs;
}, errorContext); }, errorContext);
} }
@@ -144,7 +144,7 @@ class PointTransaction {
return await withErrorHandling(async () => { return await withErrorHandling(async () => {
// Get the most recent transaction for the user to find current balance // Get the most recent transaction for the user to find current balance
const result = await couchdbService.find({ const transactions = await couchdbService.find({
selector: { selector: {
type: 'point_transaction', type: 'point_transaction',
user: userId user: userId
@@ -153,11 +153,11 @@ class PointTransaction {
limit: 1 limit: 1
}); });
if (result.docs.length === 0) { if (transactions.length === 0) {
return 0; return 0;
} }
return result.docs[0].balanceAfter; return transactions[0].balanceAfter;
}, errorContext); }, errorContext);
} }
@@ -180,12 +180,12 @@ class PointTransaction {
} }
} }
const result = await couchdbService.find({ const transactions = await couchdbService.find({
selector: selector, selector: selector,
sort: [{ createdAt: 'desc' }] sort: [{ createdAt: 'desc' }]
}); });
return result.docs; return transactions;
}, errorContext); }, errorContext);
} }