test(lint): reduce warning debt in selected test suites

src/mcp/manager.test.ts

@@ -32,6 +32,13 @@ describe('McpManager', () => {
   let registry: ToolRegistry;
   let manager: McpManager;
 
+  function assertDefined<T>(value: T | undefined): T {
+    if (value === undefined) {
+      throw new Error('Expected value to be defined');
+    }
+    return value;
+  }
+
   beforeEach(() => {
     vi.clearAllMocks();
     registry = new ToolRegistry();
@@ -48,8 +55,8 @@ describe('McpManager', () => {
     // Tool should be registered with mcp: prefix
     const tool = registry.get('mcp:test-server:do_thing');
     expect(tool).toBeDefined();
-    expect(tool!.name).toBe('mcp:test-server:do_thing');
-    expect(tool!.description).toContain('[MCP:test-server]');
+    expect(assertDefined(tool).name).toBe('mcp:test-server:do_thing');
+    expect(assertDefined(tool).description).toContain('[MCP:test-server]');
   });
 
   it('startAll handles multiple servers', async () => {
@@ -135,9 +142,9 @@ describe('McpManager', () => {
 
     const state = manager.getServerState('test-server');
     expect(state).toBeDefined();
-    expect(state!.config.name).toBe('test-server');
-    expect(state!.config.args).toEqual(['--flag']);
-    expect(state!.tools).toHaveLength(1);
+    expect(assertDefined(state).config.name).toBe('test-server');
+    expect(assertDefined(state).config.args).toEqual(['--flag']);
+    expect(assertDefined(state).tools).toHaveLength(1);
   });
 
   it('getRegisteredTools returns all MCP tools', async () => {
@@ -163,7 +170,7 @@ describe('McpManager', () => {
 
     const state = manager.getServerState('test-server');
     expect(state).toBeDefined();
-    expect(state!.config.args).toEqual(['--arg1']);
+    expect(assertDefined(state).config.args).toEqual(['--arg1']);
     expect(registry.get('mcp:test-server:do_thing')).toBeDefined();
   });