From 1a46b122e0923b916e0053750e6f3a26e71130a5 Mon Sep 17 00:00:00 2001 From: William Valentin Date: Mon, 16 Feb 2026 20:56:59 -0800 Subject: [PATCH] test(companion): cover waitForIdle abort cancellation --- docs/plans/state.json | 11 +++++++++++ src/companion/runtimeClient.test.ts | 17 +++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/docs/plans/state.json b/docs/plans/state.json index 1dd2f9d..1dffc18 100644 --- a/docs/plans/state.json +++ b/docs/plans/state.json @@ -927,6 +927,17 @@ ], "test_status": "pnpm test:run src/companion/platformClients.integration.test.ts src/companion/platformClients.test.ts src/companion/runtimeClient.test.ts src/companion/heartbeatLoop.test.ts + pnpm typecheck passing" }, + "companion-runtime-wait-for-idle-abort-coverage": { + "status": "completed", + "date": "2026-02-17", + "updated": "2026-02-17", + "summary": "Added abort-signal regression coverage for runtime `waitForIdle()` so pending idle waits cancel deterministically with explicit abort errors.", + "files_modified": [ + "src/companion/runtimeClient.test.ts", + "docs/plans/state.json" + ], + "test_status": "pnpm test:run src/companion/runtimeClient.test.ts src/companion/platformClients.test.ts src/companion/heartbeatLoop.test.ts src/companion/platformClients.integration.test.ts + pnpm typecheck passing" + }, "browser-tools-activation-clarity": { "status": "completed", "date": "2026-02-17", diff --git a/src/companion/runtimeClient.test.ts b/src/companion/runtimeClient.test.ts index 145a287..76a88e2 100644 --- a/src/companion/runtimeClient.test.ts +++ b/src/companion/runtimeClient.test.ts @@ -693,6 +693,23 @@ describe('CompanionRuntimeClient', () => { await pendingWait; }); + it('waitForIdle supports AbortSignal cancellation', async () => { + const client = new CompanionRuntimeClient({ + url: 'ws://127.0.0.1:1', + }); + const pendingWait = client.waitForEvent('agent.stream', { timeoutMs: 10_000 }).catch(() => undefined); + const controller = new AbortController(); + + const awaited = expect( + client.waitForIdle({ timeoutMs: 10_000, signal: controller.signal }), + ).rejects.toThrow('Aborted while waiting for runtime idle state'); + controller.abort(); + await awaited; + + client.clearEventSubscriptions(); + await pendingWait; + }); + it('connects and performs node registration + capability discovery', async () => { if (!LISTEN_ALLOWED) { return;