docs(01-02): complete channel/agent/routing extraction plan
- Add 01-02-SUMMARY.md with task commits, deviations, decisions - Update STATE.md: 2/3 plans complete, daemon/index.ts at 385 lines (-65%)
This commit is contained in:
William Valentin
+15
-9
@@ -9,7 +9,7 @@
|
||||
## Current Position
|
||||
|
||||
**Phase:** 1 — Daemon Decomposition
|
||||
**Plan:** 1 of 3 complete (01-01 done, next: 01-02)
|
||||
**Plan:** 2 of 3 complete (01-01, 01-02 done, next: 01-03)
|
||||
**Status:** executing
|
||||
**Progress:** ░░░░░░░░░░ 0/3 phases (phase 1 in progress)
|
||||
|
||||
@@ -17,7 +17,7 @@
|
||||
|
||||
| Phase | Status | Plans |
|
||||
|-------|--------|-------|
|
||||
| 1 — Daemon Decomposition | executing | 1/3 plans complete |
|
||||
| 1 — Daemon Decomposition | executing | 2/3 plans complete |
|
||||
| 2 — Config Overlays | not_started | — |
|
||||
| 3 — Live Ops Dashboard | not_started | — |
|
||||
|
||||
@@ -26,9 +26,11 @@
|
||||
| Metric | Value |
|
||||
|--------|-------|
|
||||
| Test count | 1077 (baseline, verified) |
|
||||
| daemon/index.ts lines | 458 (from 1088 baseline, -58%) |
|
||||
| daemon/index.ts lines | 385 (from 1087 baseline, -65%) |
|
||||
| Plan 01-01 duration | 9 min |
|
||||
| Plan 01-01 tasks | 3/3 |
|
||||
| Plan 01-02 duration | ~25 min |
|
||||
| Plan 01-02 tasks | 3/3 |
|
||||
|
||||
## Accumulated Context
|
||||
|
||||
@@ -40,12 +42,16 @@
|
||||
- Factory function pattern (initX(deps) → result) for daemon subsystem extraction
|
||||
- initTools() kept synchronous — only shutdown callbacks are async
|
||||
- Backward-compatible re-exports from daemon/index.ts for model functions
|
||||
- Deps-interface factory pattern (ChannelsDeps, AgentsDeps) for explicit dependency injection
|
||||
- registerChannels returns cronScheduler so Tier 1 cron tools can still be wired in startDaemon
|
||||
- Lifecycle wiring stays in the module that owns the resource (agents.ts owns sandbox shutdown)
|
||||
|
||||
### Technical Notes
|
||||
- daemon/index.ts now 458 lines — models, memory, tools extracted to dedicated modules
|
||||
- Pre-existing routing.ts and agents.ts extractions found (not from our plan)
|
||||
- Factory pattern: initMemory(deps) → { memoryStore, hybridSearch, memoryDir }, initTools(deps) → { toolRegistry, toolExecutor, browserManager }
|
||||
- daemon/index.ts now 385 lines — models, memory, tools, routing, agents, channels all extracted
|
||||
- Extracted modules: models.ts, memory.ts, tools.ts (Plan 01), routing.ts, agents.ts, channels.ts (Plan 02)
|
||||
- Factory pattern established: initMemory(deps), initTools(deps), initAgents(deps), registerChannels(deps), createMessageRouter(deps), createModelRouter(config)
|
||||
- Tier 1 agent tools remain in daemon/index.ts (depend on later-created objects)
|
||||
- Remaining in daemon/index.ts: session store, hooks, skills, gateway, PairingManager, signal handlers, service startup, heartbeat monitor, Tailscale serve
|
||||
- Web dashboard is vanilla JS SPA at src/gateway/ui/
|
||||
- Config loader at src/config/loader.ts, schema at src/config/schema.ts (409 lines)
|
||||
|
||||
@@ -57,9 +63,9 @@ _(none)_
|
||||
|
||||
## Session Continuity
|
||||
|
||||
**Last session:** Plan 01-01 (extract models/memory/tools) completed
|
||||
**Stopped at:** Completed 01-01-PLAN.md
|
||||
**Next action:** Execute Plan 01-02 (extract routing/channels) or continue Phase 1
|
||||
**Last session:** Plan 01-02 (extract routing/agents/channels) completed
|
||||
**Stopped at:** Completed 01-02-PLAN.md
|
||||
**Next action:** Execute Plan 01-03 (remaining extractions: skills, gateway, lifecycle/infra) or continue Phase 1
|
||||
|
||||
---
|
||||
*State initialized: 2026-02-09*
|
||||
|
||||
@@ -0,0 +1,111 @@
|
||||
---
|
||||
phase: 01-daemon-decomposition
|
||||
plan: 02
|
||||
subsystem: infra
|
||||
tags: [daemon, refactoring, module-extraction, channels, agents, routing]
|
||||
|
||||
# Dependency graph
|
||||
requires:
|
||||
- phase: 01-01
|
||||
provides: "models.ts extraction reducing daemon/index.ts baseline; memory.ts and tools.ts also pre-extracted"
|
||||
provides:
|
||||
- "src/daemon/routing.ts — message router with agent cache, sandbox wiring, audio transcription"
|
||||
- "src/daemon/agents.ts — agent config registry, agent router, sandbox manager initialization"
|
||||
- "src/daemon/channels.ts — all channel adapter registration (Telegram, Discord, Slack, WhatsApp, WebChat, cron, webhooks, Gmail)"
|
||||
affects: [01-daemon-decomposition, 02-config-overlays]
|
||||
|
||||
# Tech tracking
|
||||
tech-stack:
|
||||
added: []
|
||||
patterns: ["deps-interface factory pattern for module extraction", "lifecycle shutdown wiring in extracted modules"]
|
||||
|
||||
key-files:
|
||||
created:
|
||||
- src/daemon/routing.ts
|
||||
- src/daemon/agents.ts
|
||||
- src/daemon/channels.ts
|
||||
modified:
|
||||
- src/daemon/index.ts
|
||||
|
||||
key-decisions:
|
||||
- "Used deps-interface pattern (ChannelsDeps, AgentsDeps) for extracted factories — explicit dependency injection"
|
||||
- "Returned cronScheduler from registerChannels so startDaemon can still wire cron tools in Tier 1 registration"
|
||||
- "Accepted pre-existing memory.ts and tools.ts extractions from Plan 01 overflow (already integrated into index.ts)"
|
||||
|
||||
patterns-established:
|
||||
- "Deps-interface factory: each extracted module takes a typed deps object and returns a typed result"
|
||||
- "Lifecycle wiring stays in the module that owns the resource (agents.ts registers sandbox shutdown)"
|
||||
|
||||
# Metrics
|
||||
duration: ~25min
|
||||
completed: 2026-02-10
|
||||
---
|
||||
|
||||
# Phase 1 Plan 2: Channel/Agent/Routing Extraction Summary
|
||||
|
||||
**Extracted message routing (240 lines), agent config (48 lines), and channel registration (102 lines) from daemon/index.ts into dedicated modules, reducing it from ~459 to 385 lines**
|
||||
|
||||
## Performance
|
||||
|
||||
- **Duration:** ~25 min (across two sessions)
|
||||
- **Started:** 2026-02-10T04:08:12Z
|
||||
- **Completed:** 2026-02-10T04:34:17Z
|
||||
- **Tasks:** 3
|
||||
- **Files modified:** 4 (3 created, 1 modified)
|
||||
|
||||
## Accomplishments
|
||||
- `createMessageRouter` (~240 lines) extracted to `routing.ts` — agent cache, sandbox wiring, audio transcription, command handling
|
||||
- `initAgents` (~48 lines) extracted to `agents.ts` — AgentConfigRegistry, AgentRouter, SandboxManager with lifecycle shutdown
|
||||
- `registerChannels` (~102 lines) extracted to `channels.ts` — all 8 adapter types (Telegram, Discord, Slack, WhatsApp, WebChat, CronScheduler, WebhookHandler, GmailWatcher)
|
||||
- daemon/index.ts reduced from ~459 lines (post-Plan 01) to 385 lines; from 1087 baseline to 385 (65% reduction cumulative)
|
||||
- All 1077 tests pass, zero regressions
|
||||
|
||||
## Task Commits
|
||||
|
||||
Each task was committed atomically:
|
||||
|
||||
1. **Task 1: Extract message routing into routing.ts** — `08f5b6b` (feat)
|
||||
2. **Task 2: Extract agent config into agents.ts** — `efceb38` (feat)
|
||||
3. **Task 3: Extract channel adapter registration into channels.ts** — `35a0061` (feat)
|
||||
|
||||
## Files Created/Modified
|
||||
- `src/daemon/routing.ts` — Message router factory with agent cache, sandbox wiring, audio transcription, reset/compact/usage command handling (239 lines)
|
||||
- `src/daemon/agents.ts` — Agent config registry loading, agent router creation, sandbox manager init with lifecycle shutdown (48 lines)
|
||||
- `src/daemon/channels.ts` — All channel adapter registration: Telegram, Discord, Slack, WhatsApp, WebChat, CronScheduler, WebhookHandler, GmailWatcher (102 lines)
|
||||
- `src/daemon/index.ts` — Reduced to infrastructure wiring only; imports and calls the three new modules (385 lines)
|
||||
|
||||
## Decisions Made
|
||||
- Used deps-interface factory pattern (`ChannelsDeps`, `AgentsDeps`) for explicit dependency injection rather than passing individual arguments — keeps call sites clean and extensible
|
||||
- `registerChannels` returns `cronScheduler` (and `webhookHandler`, `gmailWatcher`) so `startDaemon` can still wire cron tools in Tier 1 tool registration
|
||||
- Accepted pre-existing `memory.ts` and `tools.ts` extractions from Plan 01 session overflow — they were already integrated into index.ts and working
|
||||
|
||||
## Deviations from Plan
|
||||
|
||||
### Auto-fixed Issues
|
||||
|
||||
**1. [Rule 3 - Blocking] Accepted pre-existing memory.ts and tools.ts extractions**
|
||||
- **Found during:** Task 1 (initial analysis)
|
||||
- **Issue:** Previous Plan 01 session extracted `src/daemon/memory.ts` and `src/daemon/tools.ts` beyond its scope; both were already integrated into index.ts imports but untracked in git
|
||||
- **Fix:** Accepted as-is — code was working and tested. These files were committed by the Plan 01 continuation agent (`fb1199a` for tools.ts, `00f8f74` for memory.ts`)
|
||||
- **Files affected:** src/daemon/memory.ts, src/daemon/tools.ts (not our commits)
|
||||
- **Verification:** All 1077 tests pass with these extractions in place
|
||||
|
||||
---
|
||||
|
||||
**Total deviations:** 1 auto-accepted (blocking — pre-existing code)
|
||||
**Impact on plan:** No scope creep. Pre-existing extractions were already working and simply acknowledged.
|
||||
|
||||
## Issues Encountered
|
||||
None — all three tasks executed cleanly.
|
||||
|
||||
## User Setup Required
|
||||
None — no external service configuration required.
|
||||
|
||||
## Next Phase Readiness
|
||||
- daemon/index.ts now contains only infrastructure wiring (385 lines): session store, hooks, skills, gateway, signal handlers, service startup, heartbeat monitor
|
||||
- Plan 01-03 (remaining extractions: skills, gateway, lifecycle/infra) can proceed — depends on the output of Plans 01 and 02
|
||||
- All daemon modules use consistent deps-interface factory pattern
|
||||
|
||||
---
|
||||
*Phase: 01-daemon-decomposition*
|
||||
*Completed: 2026-02-10*
|
||||
Reference in New Issue
Block a user