Run ruff format changes and finalize indentation and lint fixes.

tests/test_constants.py

@@ -1,104 +1,90 @@
-"""
-Tests for constants module.
-"""
-import os
-from unittest.mock import patch
+"""Tests for the canonical constants module (thechart.core.constants)."""
 
+import os
 import sys
-sys.path.insert(0, os.path.join(os.path.dirname(__file__), '..', 'src'))
+from unittest.mock import patch
 
 
 def _fresh_constants():
     """Import or reload the constants module and return it.
 
     Ensures a local binding exists in callers to avoid UnboundLocalError
-    from conditional imports in the tests.
+    while supporting env var patching between tests.
     """
     import importlib
-    # If already imported, reload to pick up env changes
-    if 'constants' in sys.modules:
-        import constants  # bind locally for importlib.reload
-        return importlib.reload(constants)
-    # Otherwise, import fresh
-    import constants
+
+    mod_name = "thechart.core.constants"
+    if mod_name in sys.modules:
+        mod = sys.modules[mod_name]
+        return importlib.reload(mod)
+    import thechart.core.constants as constants
     return constants
 
 
 class TestConstants:
-    """Test cases for the constants module."""
+    """Test cases for the canonical constants module."""
 
     def test_default_log_level(self):
-        """Test default LOG_LEVEL when not set in environment."""
         with patch.dict(os.environ, {}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_LEVEL == "INFO"
 
     def test_custom_log_level(self):
-        """Test custom LOG_LEVEL from environment."""
-        with patch.dict(os.environ, {'LOG_LEVEL': 'debug'}, clear=True):
+        with patch.dict(os.environ, {"LOG_LEVEL": "debug"}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_LEVEL == "DEBUG"
 
     def test_default_log_path(self):
-        """Test default LOG_PATH when not set in environment."""
         with patch.dict(os.environ, {}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_PATH == "/tmp/logs/thechart"
 
     def test_custom_log_path(self):
-        """Test custom LOG_PATH from environment."""
-        with patch.dict(os.environ, {'LOG_PATH': '/custom/log/path'}, clear=True):
+        with patch.dict(os.environ, {"LOG_PATH": "/custom/log/path"}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_PATH == "/custom/log/path"
 
     def test_default_log_clear(self):
-        """Test default LOG_CLEAR when not set in environment."""
         with patch.dict(os.environ, {}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_CLEAR == "False"
 
     def test_custom_log_clear_true(self):
-        """Test LOG_CLEAR when set to true in environment."""
-        with patch.dict(os.environ, {'LOG_CLEAR': 'true'}, clear=True):
+        with patch.dict(os.environ, {"LOG_CLEAR": "true"}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_CLEAR == "True"
 
     def test_custom_log_clear_false(self):
-        """Test LOG_CLEAR when set to false in environment."""
-        with patch.dict(os.environ, {'LOG_CLEAR': 'false'}, clear=True):
+        with patch.dict(os.environ, {"LOG_CLEAR": "false"}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_CLEAR == "False"
 
     def test_log_level_case_insensitive(self):
-        """Test that LOG_LEVEL is converted to uppercase."""
-        with patch.dict(os.environ, {'LOG_LEVEL': 'warning'}, clear=True):
+        with patch.dict(os.environ, {"LOG_LEVEL": "warning"}, clear=True):
             constants = _fresh_constants()
             assert constants.LOG_LEVEL == "WARNING"
 
     def test_dotenv_override(self):
-        """Test that dotenv override parameter is set to True."""
         # This is a structural test since dotenv is loaded during import
-        with patch('constants.load_dotenv') as mock_load_dotenv:
+        with patch("thechart.core.constants.load_dotenv") as mock_load_dotenv:
             import importlib
-            if 'constants' in sys.modules:
-                importlib.reload(sys.modules['constants'])
+
+            name = "thechart.core.constants"
+            if name in sys.modules:
+                importlib.reload(sys.modules[name])
             else:
-                import constants
+                import thechart.core.constants  # noqa: F401
 
             mock_load_dotenv.assert_called_once_with(override=True)
 
     def test_all_constants_are_strings(self):
-        """Test that all constants are string type."""
-        import constants
-
+        constants = _fresh_constants()
         assert isinstance(constants.LOG_LEVEL, str)
         assert isinstance(constants.LOG_PATH, str)
         assert isinstance(constants.LOG_CLEAR, str)
 
     def test_constants_not_empty(self):
-        """Test that constants are not empty strings."""
-        import constants
-
+        constants = _fresh_constants()
         assert constants.LOG_LEVEL != ""
         assert constants.LOG_PATH != ""
         assert constants.LOG_CLEAR != ""